Skip to content

Conversation

@vgeddes
Copy link
Collaborator

@vgeddes vgeddes commented Nov 10, 2020

Adds support for the following features:

  • Upward/Downward transfer of DOT.
  • Transferring bridged Ethereum assets between sibling parachains.

Both kinds of transfers are performed using the reserve-backed model as described in Polkadot Cross-Consensus Message (XCM) Format.

Changes:

  • Added a pallet token-dealer. This module includes dispatchables for initiating transfers:
    • transfer_dot_to_relaychain
    • transfer_bridged_asset_to_parachain
  • Added a crate xcm-support which contains an implementation for XCM TransactAsset trait. This is key to enabling deposits and withdrawals of assets by the XCM executor.
  • Iterative improvements to the bridged assets pallet.
  • Wiring all the above into the runtime,

There is pretty good unit test coverage for all of this in the the token-dealer module:

vincent@crake:~/code/polkadot-ethereum/parachain/pallets/token-dealer (rococo-v1)$ cargo test
   Compiling artemis-xcm-support v0.1.0 (/home/vincent/code/polkadot-ethereum/parachain/primitives/xcm-support)
   Compiling artemis-token-dealer v0.1.1 (/home/vincent/code/polkadot-ethereum/parachain/pallets/token-dealer)
    Finished test [unoptimized + debuginfo] target(s) in 8.58s
     Running /home/vincent/code/polkadot-ethereum/parachain/target/debug/deps/artemis_token_dealer-10cd52ae3eab93d4

running 3 tests
test tests::transfer_foreign_eth_to_parachain ... ok
test tests::transfer_dot_to_relay_chain ... ok
test tests::transfer_native_eth_to_parachain ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

   Doc-tests artemis-token-dealer

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

@vgeddes
Copy link
Collaborator Author

vgeddes commented Nov 12, 2020

Note: Leaving this PR in draft mode until upstream dependencies have stabilized (i.e. the features we need have been merged into the master branches of Substrate, Polkadot, and Cumulus).

Copy link
Contributor

@philipstanislaus philipstanislaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few comments 🎉

to the relaychain node.\n\n\
{} [parachain-args] -- [relaychain-args]",
Self::executable_name()
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, These changes to the files under parachain/node/src/ were necessary to support the CLI interfaces/abstractions provided by the Polkadot in the gav-xcmp branch.

@musnit
Copy link
Collaborator

musnit commented Jan 8, 2021

@vgeddes can close?

@vgeddes
Copy link
Collaborator Author

vgeddes commented Jan 9, 2021

Obsoleted by #200

@vgeddes vgeddes closed this Jan 9, 2021
@vgeddes vgeddes deleted the rococo-v1 branch January 16, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add token dealer pallet for XCMP Update dependencies for Rococo + XCMP Adapt assets pallet to work with XCMP

4 participants