-
Notifications
You must be signed in to change notification settings - Fork 138
Support asset transfers via XCM #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note: Leaving this PR in draft mode until upstream dependencies have stabilized (i.e. the features we need have been merged into the master branches of Substrate, Polkadot, and Cumulus). |
philipstanislaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few comments 🎉
| to the relaychain node.\n\n\ | ||
| {} [parachain-args] -- [relaychain-args]", | ||
| Self::executable_name() | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, These changes to the files under parachain/node/src/ were necessary to support the CLI interfaces/abstractions provided by the Polkadot in the gav-xcmp branch.
|
@vgeddes can close? |
|
Obsoleted by #200 |
Adds support for the following features:
Both kinds of transfers are performed using the reserve-backed model as described in Polkadot Cross-Consensus Message (XCM) Format.
Changes:
token-dealer. This module includes dispatchables for initiating transfers:transfer_dot_to_relaychaintransfer_bridged_asset_to_parachainxcm-supportwhich contains an implementation for XCMTransactAssettrait. This is key to enabling deposits and withdrawals of assets by the XCM executor.There is pretty good unit test coverage for all of this in the the
token-dealermodule: