Skip to content

Conversation

@alistair-singh
Copy link
Contributor

@alistair-singh alistair-singh commented Mar 29, 2023

The current bridge hub work relies on master branches for polkadot and substrate dependencies.

The upgrade consists of:

  1. Remove the deprecated generate_store macro. [Deprecation] deprecate trait Store in FRAME storage paritytech/polkadot-sdk#222
  2. Remove deprecated Weights::from_ref_time. Deprecate Weight::from_{ref_time, proof_size} paritytech/substrate#13475

Snowfork Cumulus companion: Snowfork/cumulus#7

@alistair-singh alistair-singh marked this pull request as ready for review March 29, 2023 07:59
@alistair-singh alistair-singh requested review from vgeddes and yrong March 29, 2023 07:59
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets also update codec, serde, and scale-info deps to match Substrate master, where I'm seeing the following versions in use:

  • codec: 3.2.2
  • serde: 1.0.136
  • scale-info: 2.1.1

@alistair-singh
Copy link
Contributor Author

Lets also update codec, serde, and scale-info deps to match Substrate master, where I'm seeing the following versions in use:

The current branch I have based this on bridge-hub-rococo-wococo has the following versions with the bridge-hub-rococo runtime.

  • codec: 3.2.1
  • serde: 1.0.156
  • scale-info: 2.3.1

I have updated our pallets to match those versions instead.
See https://github.com/Snowfork/cumulus/blob/alistair/use-rococo-bridge/parachains/runtimes/bridge-hubs/bridge-hub-rococo/Cargo.toml

Copy link
Contributor

@yrong yrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@vgeddes vgeddes merged commit 3db2d69 into main Apr 2, 2023
@vgeddes vgeddes deleted the alistair/use-rococo-bridge branch April 2, 2023 10:00
vgeddes added a commit that referenced this pull request Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants