-
Notifications
You must be signed in to change notification settings - Fork 137
Use master branches for parity dependencies
#796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vgeddes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets also update codec, serde, and scale-info deps to match Substrate master, where I'm seeing the following versions in use:
- codec: 3.2.2
- serde: 1.0.136
- scale-info: 2.1.1
The current branch I have based this on
I have updated our pallets to match those versions instead. |
yrong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
vgeddes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
The current bridge hub work relies on
masterbranches forpolkadotandsubstratedependencies.The upgrade consists of:
generate_storemacro. [Deprecation] deprecatetrait Storein FRAME storage paritytech/polkadot-sdk#222Weights::from_ref_time. DeprecateWeight::from_{ref_time, proof_size}paritytech/substrate#13475Snowfork Cumulus companion: Snowfork/cumulus#7