[Bugfix] Always close StarRocksSourceDataReader and check keepAliveMin is valid#138
Merged
chaoyli merged 2 commits intoStarRocks:mainfrom Nov 10, 2022
Merged
[Bugfix] Always close StarRocksSourceDataReader and check keepAliveMin is valid#138chaoyli merged 2 commits intoStarRocks:mainfrom
chaoyli merged 2 commits intoStarRocks:mainfrom
Conversation
banmoy
changed the title
waittttting
approved these changes
Nov 9, 2022
chaoyli
reviewed
Nov 10, 2022
|
|
||
| private void internalClose() { | ||
| if (dataReaderClosed.compareAndSet(false, true)) { | ||
| LOG.info("Close reader"); |
Collaborator
There was a problem hiding this comment.
Add a request in the info
chaoyli
approved these changes
Nov 10, 2022
chaoyli
approved these changes
Nov 10, 2022
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Nov 10, 2022
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Nov 10, 2022
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Nov 10, 2022
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Nov 10, 2022
chaoyli
pushed a commit
that referenced
this pull request
Nov 15, 2022
chaoyli
pushed a commit
that referenced
this pull request
Nov 15, 2022
chaoyli
pushed a commit
that referenced
this pull request
Nov 15, 2022
chaoyli
pushed a commit
that referenced
this pull request
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #
Problem Summary(Required) ：
StarRocksDynamicSourceFunctiondoes not closeStarRocksSourceDataReaderif flink job finishes normally, which will not close the connection with BEkeepAliveMindoes not overflow when convertinginttoshortChecklist: