EFCore analyzer improvements#941
Open
JoschiZ wants to merge 1 commit intoSteveDunn:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DoNotCompareWithPrimitivesInEfCoreAnalyzerfromErrortoWarning: IQueryable is not only used in the context of EFCore, but wen cannot really differentiate between an EFCore IQueryable and something else. Thus this should probably be a warning, because false positives are likely.DoNotAccessValueInEfCoreAnalyzer: An analyzer that catches the access toMyVo.Valueinside the expression tree ofIQueryables as well as the old query syntax. Accessing those properties inside the context of EFCore queries will crash during runtime, because the query cannot be translated see [Question] Vogen in "dynamic" EntityFramework Core situations #699IQueryableextensions.