Skip to content

Timespan update #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
briandrawert merged 3 commits into from
Mar 6, 2021
Merged

Timespan update #79

briandrawert merged 3 commits into from
Mar 6, 2021

Conversation

@BryanRumsey
Copy link
Contributor

@BryanRumsey BryanRumsey commented Mar 2, 2021

New Features

  • add_mesh function sets a mesh object and the list of type ids to the model
  • timespan function now sets the models timestep_size

Bug Fixes

  • Fixed bug in the models str function

This was linked to issues Mar 2, 2021
Need add_mesh function in the Model to handle setting listofTypeIDs #73
Closed
timespan function of the Model should also take the timestep_size as an argument #74
Closed
@briandrawert briandrawert merged commit f6641b7 into develop Mar 6, 2021
@briandrawert briandrawert deleted the timespan-update branch March 6, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@makdl makdl makdl approved these changes

@briandrawert briandrawert Awaiting requested review from briandrawert

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

timespan function of the Model should also take the timestep_size as an argument Need add_mesh function in the Model to handle setting listofTypeIDs

4 participants

@BryanRumsey @makdl @briandrawert