Skip to content
This repository was archived by the owner on Sep 22, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add unit test for DataFrame.length === 0
  • Loading branch information
mjclawar committed May 17, 2017
commit 893bff7a88aa4811c70db270b6f795077c0946d4
15 changes: 15 additions & 0 deletions src/es6/__tests__/core/frame.js
Original file line number Diff line number Diff line change
Expand Up @@ -1014,4 +1014,19 @@ describe('frame', () => {
expect(df2.get('q').name).toEqual('q');
});
});

describe('length', () => {
it('Has length zero when empty DataFrame', () => {
const df = new DataFrame();
expect(df.length).toEqual(0);

const df2 = new DataFrame([]);
expect(df2.length).toEqual(0);
});

it('Estimates non-zero length properly', () => {
const df = new DataFrame(Immutable.Map({x: new Series([1, 2, 5, 4, 3])}));
expect(df.length).toEqual(5);
});
});
});
4 changes: 1 addition & 3 deletions src/es6/core/frame.js
Original file line number Diff line number Diff line change
Expand Up @@ -327,9 +327,7 @@ export default class DataFrame extends NDFrame {
* df.length;
*/
get length(): number {
if (this._data.keySeq().size === 0)
return 0;
return Math.max(...this._data.keySeq().map(k => this.get(k).length).toArray());
return Math.max(0, ...this.columns.map(k => this.get(k).length).toArray());
}

/**
Expand Down
15 changes: 15 additions & 0 deletions src/js/__tests__/core/frame.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions src/js/core/frame.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.