Skip to content

Sgproj 1461 Module upgrade #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DJKaswa wants to merge 23 commits into from
Closed

Sgproj 1461 Module upgrade #15

DJKaswa wants to merge 23 commits into from

Conversation

@DJKaswa
Copy link
Contributor

@DJKaswa DJKaswa commented Jul 20, 2022

Change description

Upgrades module's provider to 4.22.0 and sets it to be backward compatible with older versions since some projects are specifically locked on older versions.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

DJKaswa added 20 commits August 4, 2021 11:16
Added Readme and gitignore.
90c681a
Added output.tf.
838bc2c
Renames acm_domain_name to acm_certificate_name to reflect the actual…
eca36c7 
… function of the variable.
Updates the documentation.
3b1150e
Updates the documentation.
735b720
Formats the file.
6799b2e
Corrected variable names to be used effectively.
740d446
Merge branch 'main' of https://github.com/StratusGrid/terraform-aws-a…
f95adaf 
…cm-certificate-creation into feature
Applies the new template to the repo.
d1082ab
Renames files to match requirement of the new template.
0bb000c
New Readme generated.
bdf2919
Updates acm_domain_name description.
97cc33c
Update the example to show the complete steps to take to instantiate …
fd1ee63 
…the module.
Updates ReadMe.
ee4a534
Makes a small modification to test tempo.
fd46a4f
Upgrades aws provider to 4.0
f6d642b
Pulls changes from main
467e504
Corrects provider version to the newest version
00ed1d0
Sets provider to accept versions prior to 4.22.0.
f7f265a
Sets provider to accept versions prior to 4.22.0.
5805d06
@DJKaswa DJKaswa requested a review from rchildress87 July 20, 2022 17:38
rchildress87
rchildress87 reviewed Aug 1, 2022
View reviewed changes
@DJKaswa
Copy link
Contributor Author

DJKaswa commented Sep 17, 2022

closing this branch as no upgrade will be done on the provider.

@DJKaswa DJKaswa closed this Sep 17, 2022
@DJKaswa DJKaswa deleted the SGPROJ-1461 branch December 8, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@rchildress87 rchildress87 rchildress87 left review comments

@wesleykirklandsg wesleykirklandsg wesleykirklandsg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DJKaswa @rchildress87 @wesleykirklandsg