Add u- and v-band filter and photometric columns to target and fluxstd tables#141
Merged
Conversation
Add filter_u (FK to filter_name), psf_mag_u, psf_mag_error_u, psf_flux_u,
psf_flux_error_u, total_flux_u, total_flux_error_u (target only), and
fiber_mag_u (target only) columns before the existing g-band columns.
Includes Alembic migration with explicit FK constraint names following the
established {table}_{column}_fkey convention.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add filter_v (FK to filter_name), psf_mag_v, psf_mag_error_v, psf_flux_v,
psf_flux_error_v, total_flux_v, total_flux_error_v (target only), and
fiber_mag_v (target only) columns between u-band and g-band columns.
Also update filter_u comments to include u_skymapper as an example.
Includes Alembic migration with explicit FK constraint names following the
established {table}_{column}_fkey convention.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filter_u,filter_v(FK →filter_name) and corresponding photometric columns (psf_flux,psf_flux_error,psf_mag,psf_mag_error,total_flux,total_flux_error,fiber_mag) to thetargettablefiber_magandtotal_flux) to thefluxstdtable{table}_{column}_fkeyconventiondocs/schema/target.md,docs/schema/fluxstd.md)pfsa-db01-gb:20260520-181828_5df293bb75f2: add u-band columns20260521-090910_31f82c75c58d: add v-band columns (also updatesfilter_ucomment to includeu_skymapper)Test plan
python -c "from targetdb.models.target import target; from targetdb.models.fluxstd import fluxstd")pytest tests/)target_filter_u_fkey,target_filter_v_fkey,fluxstd_filter_u_fkey,fluxstd_filter_v_fkeyare present🤖 Generated with Claude Code