Speed Up Unittests dramatically #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids making an HTTP request in the AuthClient constructor
This speeds up the test suite by not fetching the discovery docs as often
One test had the mock set to Session rather than Session.request. This was causing the test to fail with the new discovery_doc stubs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses Issues #4 and #12.
This implements a discovery_doc cache so that HTTP requests are not required on the AuthClient constructor.
This also creates proper fixtures and mocks to be used in the unit tests.
The testing suite runs extremely fast now and only several HTTP requests are made.