Skip to content

Issue #ED-4197 fix: User is not getting feedback #3606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swayangjit merged 3 commits into from
May 3, 2024
Merged

Issue #ED-4197 fix: User is not getting feedback #3606

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aaa0c49
Issue #ED-4197 fix: User is not getting feedback
sujithsojan May 2, 2024
e461cc2
Issue #ED-4197 fix: Fixing sonar scan error
sujithsojan May 2, 2024
587db38
Merge branch 'release-7.0.0' of https://github.com/Sunbird-Ed/Sunbird…
sujithsojan May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/app/player/player.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,9 @@ export class PlayerPage implements OnInit, OnDestroy, PlayerActionHandlerDelegat
this.playerType = 'sunbird-quml-player';
this.playQumlContent();
} else {
const questionSetData = await this.contentService.getQuestionSetChildren(this.config['metadata']['identifier']);
this.config['metadata']['children'] = await this.contentService.getQuestionSetChildren(this.config['metadata']['identifier']);
let questionId: string[] = [];
questionSetData.forEach(item => {
this.config['metadata']['children'].forEach(item => {
if (item.children) {
item.children.forEach(child => {
if (child.identifier) {
Expand All @@ -155,10 +155,18 @@ export class PlayerPage implements OnInit, OnDestroy, PlayerActionHandlerDelegat
}
});
this.contentService.getQuestionList(questionId).subscribe((response) => {
this.config['metadata']['children'] = response.questions;
const questions = response.questions;
this.config['metadata']['children'].forEach((childArray) => {
if (childArray.children) {
childArray.children.length = 0;
questions.forEach(question => {
childArray.children.push(question);
});
}
});
this.playerType = 'sunbird-quml-player';
this.playQumlContent();
});
});
}
} else if(["video/mp4", "video/webm"].includes(this.config['metadata']['mimeType']) && this.checkIsPlayerEnabled(this.playerConfig , 'videoPlayer').name === "videoPlayer"){
if(!this.platform.is('ios')){
Expand Down Expand Up @@ -762,7 +770,7 @@ export class PlayerPage implements OnInit, OnDestroy, PlayerActionHandlerDelegat
config: this.config.config,
metadata: this.config.metadata
};

setTimeout(() => {
const qumlElement = document.createElement('sunbird-quml-player');
qumlElement.setAttribute('player-config', JSON.stringify(playerConfig));
Expand All @@ -786,4 +794,4 @@ export class PlayerPage implements OnInit, OnDestroy, PlayerActionHandlerDelegat
console.error("Invalid player type or missing config.");
}
}
}
}