Skip to content

Issue #SB-17249 fix: added content share link with app link with UTM #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swayangjit merged 4 commits into from
Jan 16, 2020
Merged

Issue #SB-17249 fix: added content share link with app link with UTM #457

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae003cc
Issue #SB-17256 fix: added content share link with app link with UTM
raghav14 Jan 16, 2020
00e9c4d
Issue #SB-7249 fix: added content utm
raghav14 Jan 16, 2020
519744f
Issue #SB-7249 fix: modififcation
raghav14 Jan 16, 2020
b8a0784
Issue #SB-17249 fix: added string
raghav14 Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Issue #SB-17249 fix: added string
  • Loading branch information
@raghav14
raghav14 committed Jan 16, 2020
commit b8a0784911386a28e101be5b9808d591e8986e6b
1 change: 1 addition & 0 deletions src/assets/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,7 @@
"TRY_AGAIN": "TRY AGAIN",
"TRY_BEFORE_RATING": "Please try the content before rating it.",
"TRY_DIFF_QR": "Try a different QR code?",
"TRY_CONTENT_ON": "Try this content on the mobile app: ",
"UNABLE_TO_FETCH_CONTENT": "Unable to fetch retired content",
"UNENROLL_CONFIRMATION_MESSAGE": "You can rejoin an active or upcoming batch later",
"UNENROLL_FROM_COURSE": "Leave Training",
Expand Down
3 changes: 2 additions & 1 deletion src/services/content/content-share-handler.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ describe('ContentShareHandlerService', () => {
};
const mockCommonUtilService: Partial<CommonUtilService> = {
showToast: jest.fn(),
getAppName: jest.fn(() => Promise.resolve('resolved'))
getAppName: jest.fn(() => Promise.resolve('resolved')),
translateMessage: jest.fn(() => 'Try this: ')
};
const mockSocialSharing: Partial<SocialSharing> = {
share: jest.fn()
Expand Down
2 changes: 1 addition & 1 deletion src/services/content/content-share-handler.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export class ContentShareHandlerService {
InteractSubtype.SHARE_LIBRARY_SUCCESS,
content.contentData.contentType, corRelationList, rollup);
let shareLink = content.contentData.name + ' on ' + this.appName + ' ' + this.getContentUtm(shareParams.link, content);
shareLink = shareLink + '\n\n' + await this.getPackageNameWithUTM(true);
shareLink = shareLink + `\n\n${this.commonUtilService.translateMessage('TRY_CONTENT_ON')}` + await this.getPackageNameWithUTM(true);
this.social.share(null, null, null, shareLink);
} else if (shareParams && shareParams.saveFile) {
exportContentRequest = {
Expand Down