Update ImageWorkshopLayer.php#14
Closed
mbeech wants to merge 1 commit into
Closed
Conversation
Fixing a bug when adding a layer on top after resizing with converse proportions
Owner
|
Hello @mbeech you found a beautiful bug ! But you can't apply a mergeAll, because users do not necessarily want to have merged layers (if the layer has sublayers, sublayers have to be distinct, and not all merged in one after a resize). Anyway, thank you for reporting the bug and proposing a solution, I'm working on a fix ;) |
Author
|
Hi Sybio Yes I did think that, but I tried so much that was the only thing I could get working! Let me know if you need any help with the fix. Thanks |
Owner
Author
|
Good work! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a bug when adding a layer on top after resizing with converse proportions.
To recreate the bug:
Expected result:
image.png resized to 770 x 770px with the watermark on top with opacity 20%
Actual result:
blank image resized to 770 x 770px with the watermark on top with opacity 20%