Skip to content

Conversation

jrushlow
Copy link
Contributor

@jrushlow jrushlow commented Mar 1, 2024

  • Update docs to say "hey, if your users id is there email" this method won't work as expected

@jrushlow jrushlow added Status: Needs Work Additional work is needed Feature New Feature labels Mar 1, 2024
Copy link
Contributor

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, this makes sense to me. I guess no changes to MakerBundle, right? Just need to mention this in the docs

@jrushlow jrushlow force-pushed the feature/flush-requests branch from e4cae9d to 239a9ad Compare March 1, 2024 16:49
@jrushlow jrushlow marked this pull request as ready for review March 1, 2024 16:50
@jrushlow jrushlow added Status: Needs Review Needs to be reviewed and removed Status: Needs Work Additional work is needed labels Mar 1, 2024
@jrushlow jrushlow changed the title [persistence] add ability to remove ResetPasswordRequest objects prog… [persistence] remove ResetPasswordRequest objects programmatically Mar 1, 2024
README.md Outdated
Typically, you'd call this method when you need to remove request object(s) for
a user who changed their email address due to suspicious activity and potentially
has valid request objects in persistence with their "old" compromised email address.
In such cases, pass the `user` object to `removeRequest()`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a quick symfony controller example - like a profile() action with a pretend ProfileFormType. Set an $email variable to the current user’s email before we handle the submit. Then on success, check to see if it’s changed. If it did, call our method.

@jrushlow jrushlow force-pushed the feature/flush-requests branch from b00491a to 2bc192a Compare March 5, 2024 08:54
@jrushlow jrushlow added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Mar 5, 2024
@jrushlow jrushlow merged commit 598fc74 into SymfonyCasts:main Mar 5, 2024
@jrushlow jrushlow deleted the feature/flush-requests branch March 5, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants