Skip to content

Conversation

jrushlow
Copy link
Contributor

@jrushlow jrushlow commented Apr 11, 2024

  • adds type annotations to properties in ResetPasswordRequestTrait
  • adds the void return type annotation to ResetPasswordRequestTrait::initialize()

These annotations will be replaced with native PHP types in v2.0.0

  • app test locally

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jrushlow jrushlow merged commit c6f9694 into SymfonyCasts:main Apr 16, 2024
@jrushlow jrushlow deleted the feature/trait-property-types branch April 16, 2024 12:10
jrushlow added a commit to jrushlow/reset-password-bundle that referenced this pull request Apr 16, 2024
* main:
  feature SymfonyCasts#305 [trait] add type annotations to ResetPasswordRequestTrait
@jrushlow jrushlow mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants