New uvmap for MeshDraft.Prism

[BasmanovDaniil]

Prism (on the right) should have the same uvmap as Cylinder (on the left).

ProceduralToolkit/Runtime/MeshDraftPrimitives.cs

Lines 322 to 362 in 5c0ffba

	public static MeshDraft Prism(float radius, int segments, float height, bool generateUV = true)
	{
	float segmentAngle = 360f/segments;
	float currentAngle = 0;
	Vector3 halfHeightUp = Vector3.up*height/2;
	var lowerRing = new List<Vector3>(segments);
	var lowerDiskUV = new List<Vector2>();
	var upperRing = new List<Vector3>(segments);
	var upperDiskUV = new List<Vector2>();
	for (var i = 0; i < segments; i++)
	{
	var point = Geometry.PointOnCircle3XZ(radius, currentAngle);
	lowerRing.Add(point - halfHeightUp);
	upperRing.Add(point + halfHeightUp);
	if (generateUV)
	{
	Vector2 uv = Geometry.PointOnCircle2(0.5f, currentAngle) + new Vector2(0.5f, 0.5f);
	upperDiskUV.Add(uv);
	uv.x = 1 - uv.x;
	lowerDiskUV.Add(uv);
	}
	currentAngle += segmentAngle;
	}
	var draft = new MeshDraft {name = "Prism"}
	.AddFlatQuadBand(lowerRing, upperRing, generateUV);
	if (generateUV)
	{
	draft.AddTriangleFan(upperRing, Vector3.up, upperDiskUV)
	.AddTriangleFan(lowerRing, Vector3.down, lowerDiskUV, true);
	}
	else
	{
	draft.AddTriangleFan(upperRing, Vector3.up)
	.AddTriangleFan(lowerRing, Vector3.down, true);
	}
	return draft;
	}

ProceduralToolkit/Runtime/MeshDraftPrimitives.cs

Lines 367 to 414 in 5c0ffba

	public static MeshDraft Cylinder(float radius, int segments, float height, bool generateUV = true)
	{
	float segmentAngle = 360f/segments;
	float currentAngle = 0;
	Vector3 halfHeightUp = Vector3.up*height/2;
	var draft = new MeshDraft {name = "Cylinder"};
	var lowerRing = new List<Vector3>(segments);
	var lowerDiskUV = new List<Vector2>();
	var upperRing = new List<Vector3>(segments);
	var upperDiskUV = new List<Vector2>();
	var strip = new List<Vector3>();
	var stripNormals = new List<Vector3>();
	var stripUV = new List<Vector2>();
	for (var i = 0; i < segments; i++)
	{
	AddCylinderPoints(radius, currentAngle, halfHeightUp, generateUV,
	ref strip, ref stripUV, ref stripNormals, out Vector3 lowerVertex, out Vector3 upperVertex);
	lowerRing.Add(lowerVertex);
	upperRing.Add(upperVertex);
	if (generateUV)
	{
	Vector2 uv = Geometry.PointOnCircle2(0.5f, currentAngle) + new Vector2(0.5f, 0.5f);
	upperDiskUV.Add(uv);
	uv.x = 1 - uv.x;
	lowerDiskUV.Add(uv);
	}
	currentAngle += segmentAngle;
	}
	AddCylinderPoints(radius, currentAngle, halfHeightUp, generateUV,
	ref strip, ref stripUV, ref stripNormals, out _, out _);
	if (generateUV)
	{
	draft.AddTriangleFan(lowerRing, Vector3.down, lowerDiskUV, true);
	draft.AddTriangleFan(upperRing, Vector3.up, upperDiskUV);
	draft.AddTriangleStrip(strip, stripNormals, stripUV);
	}
	else
	{
	draft.AddTriangleFan(lowerRing, Vector3.down, true);
	draft.AddTriangleFan(upperRing, Vector3.up);
	draft.AddTriangleStrip(strip, stripNormals);
	}
	return draft;
	}

[Mr-sB]

Hello! I find the help wanted, so i try to modify your code to solve this problem. I modify MeshDraft.AddFlatQuadBand to change uvmap, here is the change:

        /// <summary>
        /// Adds a band made from quads to the draft
        /// </summary>
        public MeshDraft AddFlatQuadBand(IReadOnlyList<Vector3> lowerRing, IReadOnlyList<Vector3> upperRing, bool generateUV)
        {
            if (lowerRing.Count != upperRing.Count)
            {
                throw new ArgumentException("Array sizes must be equal");
            }
            if (lowerRing.Count < 3)
            {
                throw new ArgumentException("Array sizes must be greater than 2");
            }

            Vector3 lower0, upper0, lower1, upper1;
            int ringCount = lowerRing.Count;
            float uvXStep = 1f / ringCount;
            for (int i = 0; i < ringCount - 1; i++)
            {
                lower0 = lowerRing[i];
                lower1 = lowerRing[i + 1];
                upper0 = upperRing[i];
                upper1 = upperRing[i + 1];
                if (generateUV)
                {
                    var uvX0 = i * uvXStep;
                    var uxX1 = (i + 1) * uvXStep;
                    Vector2 uv00 = new Vector2(uvX0, 0);
                    Vector2 uv10 = new Vector2(uxX1, 0);
                    Vector2 uv01 = new Vector2(uvX0, 1);
                    Vector2 uv11 = new Vector2(uxX1, 1);
                    AddQuad(lower1, upper1, upper0, lower0, true, uv00, uv01, uv11, uv10);
                }
                else
                {
                    AddQuad(lower1, upper1, upper0, lower0, true);
                }
            }

            lower0 = lowerRing[ringCount - 1];
            lower1 = lowerRing[0];
            upper0 = upperRing[ringCount - 1];
            upper1 = upperRing[0];
            if (generateUV)
            {
                var uvX0 = (ringCount - 1) * uvXStep;
                var uxX1 = 1;
                Vector2 uv00 = new Vector2(uvX0, 0);
                Vector2 uv10 = new Vector2(uxX1, 0);
                Vector2 uv01 = new Vector2(uvX0, 1);
                Vector2 uv11 = new Vector2(uxX1, 1);
                AddQuad(lower1, upper1, upper0, lower0, true, uv00, uv01, uv11, uv10);
            }
            else
            {
                AddQuad(lower1, upper1, upper0, lower0, true);
            }
            return this;
        }

If you think it works, please consider to merge.
#71

[BasmanovDaniil]

Thank you for the help! Really appreciate it. I will take a look at the code this weekend.

[Mr-sB]

It's my pleasure to contribute to the great package!

[BasmanovDaniil]

Looks good, merged in, thanks again!