Student submitting MCQ question: comments are not loading

[damithc]

Situation:
A student is editing responses to an MCQ question that she submitted earlier, and reported that she is seeing the following error.

It turns out the submission page is not loading the comments she submitted earlier i.e., clicking this button given below shows an empty form instead of the comment she submitted previously.

When she enters a new comment, the above error message shows. I've checked the database to confirm the comment is in the database, and it even shows up in the results page when instructor views it.

[damithc]

If this is an actual bug, we need to fix soon, as the students of that session are unable to see/update the comments they entered previously.

[samuelfangjw]

Did some investigation, seems like a valid bug. Part of the issues stem from here:

teammates/src/web/app/pages-session/session-submission-page/session-submission-page.component.ts

Lines 533 to 580 in 7dfda8b

	if (this.getQuestionSubmissionFormMode(model) === QuestionSubmissionFormMode.FIXED_RECIPIENT) {
	// need to generate a full list of submission forms
	model.recipientList.forEach((recipient: FeedbackResponseRecipient) => {
	const matchedExistingResponse: FeedbackResponse | undefined =
	existingResponses.responses.find(
	(response: FeedbackResponse) => response.recipientIdentifier === recipient.recipientIdentifier);
	const submissionForm: FeedbackResponseRecipientSubmissionFormModel = {
	recipientIdentifier: recipient.recipientIdentifier,
	responseDetails: matchedExistingResponse
	? matchedExistingResponse.responseDetails
	: this.feedbackResponsesService.getDefaultFeedbackResponseDetails(model.questionType),
	responseId: matchedExistingResponse ? matchedExistingResponse.feedbackResponseId : '',
	isValid: true,
	};
	if (matchedExistingResponse && matchedExistingResponse.giverComment) {
	submissionForm.commentByGiver = this.getCommentModel(matchedExistingResponse.giverComment);
	}
	model.recipientSubmissionForms.push(submissionForm);
	});
	}
	if (this.getQuestionSubmissionFormMode(model) === QuestionSubmissionFormMode.FLEXIBLE_RECIPIENT) {
	// need to generate limited number of submission forms
	let numberOfRecipientSubmissionFormsNeeded: number =
	model.customNumberOfEntitiesToGiveFeedbackTo - existingResponses.responses.length;
	existingResponses.responses.forEach((response: FeedbackResponse) => {
	model.recipientSubmissionForms.push({
	recipientIdentifier: response.recipientIdentifier,
	responseDetails: response.responseDetails,
	responseId: response.feedbackResponseId,
	isValid: true,
	});
	});
	// generate empty submission forms
	while (numberOfRecipientSubmissionFormsNeeded > 0) {
	model.recipientSubmissionForms.push({
	recipientIdentifier: '',
	responseDetails: this.feedbackResponsesService.getDefaultFeedbackResponseDetails(model.questionType),
	responseId: '',
	isValid: true,
	});
	numberOfRecipientSubmissionFormsNeeded -= 1;
	}
	}
	}, (resp: ErrorMessageOutput) => this.statusMessageService.showErrorToast(resp.error.message));
	}

For FIXED_RECIPIENT types, existing comments are added (lines 547-549). However, for FLEXIBLE_RECIPIENT type, existing comments are not added to the form model.

However, the issue doesn't seem to be as simple as adding the comment to the form model for FLEXIBLE_RECIPIENT type. Currently, when submitting responses, we don't account for a change in recipients of the comment (i.e. add comment -> change recipient -> submit response -> error because comment is still tied to old respondent).