Enable PreStackCocaGathers3D - take two #616
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianMichell
requested changes
Aug 28, 2025
BrianMichell
requested changes
Sep 2, 2025
tasansal
force-pushed
the
caca-take-2
branch
from
96040b4 to
0301218
Compare
tasansal
suggested changes
Sep 3, 2025
Contributor
tasansal
left a comment
tasansal
left a comment
There was a problem hiding this comment.
this implementation is not valid. as i said before the coordinates don't always share the same dimensions we have to handle this more explicitly.
Contributor
There was a problem hiding this comment.
this implementation is not valid. as i said before the coordinates don't always share the same dimensions we have to handle this more explicitly.
tasansal
force-pushed
the
caca-take-2
branch
from
0301218 to
8e18fe5
Compare
This was referenced Sep 7, 2025
Contributor
|
superseeded by #644 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have completely re-done the non-dimensional coordinate handling logic