Skip to content

v1 implementation of AutoChannelWrap grid override #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tasansal merged 12 commits into from
Sep 5, 2025
Merged

v1 implementation of AutoChannelWrap grid override #632

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bcc4ba6
AutoChannelWrap over updated-v1
dmitriyrepin Sep 4, 2025
2b6811f
Fix test
dmitriyrepin Sep 4, 2025
dedddb2
rename function for new behaviour and improve type hint for grid_over…
tasansal Sep 5, 2025
3aab1fd
simplify metadata handling
tasansal Sep 5, 2025
b983a7e
lint
tasansal Sep 5, 2025
fd878f3
gridOverride is not required
tasansal Sep 5, 2025
03e323f
remove unnecessary byte order change, handled upstream.
tasansal Sep 5, 2025
6b14172
remove rtol adds, tests pass.
tasansal Sep 5, 2025
a9d89e3
remove expected behaviour comment
tasansal Sep 5, 2025
40b124e
clean up tests
tasansal Sep 5, 2025
642bd66
use grouped assignments to fix PLR915
tasansal Sep 5, 2025
63e9b71
add comments to clarify
tasansal Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unnecessary byte order change, handled upstream.
  • Loading branch information
@tasansal
tasansal committed Sep 5, 2025
commit 03e323fcb2f4149db4189e5047cb7213689c4ae7
4 changes: 2 additions & 2 deletions tests/integration/testing_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ def validate_variable( # noqa PLR0913
assert expected_names == actual_names

# Compare field types
expected_types = [data_type[name].newbyteorder("=") for name in data_type.names]
actual_types = [arr.dtype[name].newbyteorder("=") for name in arr.dtype.names]
expected_types = [data_type[name] for name in data_type.names]
actual_types = [arr.dtype[name] for name in arr.dtype.names]
assert expected_types == actual_types

# Compare field offsets fails.
Expand Down