Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
88 commits
Select commit Hold shift + click to select a range
8eeddea
update project metadata and deps
tasansal Apr 29, 2025
293a714
update project metadata and deps
tasansal Apr 29, 2025
faacbaa
add schemas
tasansal Apr 29, 2025
1a1e743
Relocate quickstart notebook to tutorials directory
tasansal Apr 29, 2025
3c8ea4d
update docs dependencies
tasansal Apr 29, 2025
53ecaa9
add new docs
tasansal Apr 29, 2025
da09c4b
remove incorrect exclude
tasansal Apr 29, 2025
0d59c95
remove duplicate doc directive
tasansal Apr 29, 2025
793f3f1
fix creation notebook
tasansal Apr 29, 2025
0e64e09
Add basic unit test for v1 dataset schema validation
tasansal Apr 29, 2025
a1a312e
update lockfile
tasansal Apr 30, 2025
dfe7751
fix broken creation nb
tasansal May 7, 2025
f6b2c34
update lockfile
tasansal May 7, 2025
dbec58e
lint v1 files
tasansal May 7, 2025
ecb69d6
update lock file
tasansal May 27, 2025
9dd9fbc
schema_v1-dataset_builder-add_dimension
dmitriyrepin Jun 24, 2025
5816f83
V1 schema review (#553)
BrianMichell Jun 26, 2025
f88531e
Merge remote-tracking branch 'upstream/v1' into v1
dmitriyrepin Jun 26, 2025
1358f95
First take on add_dimension(), add_coordinate(), add_variable()
dmitriyrepin Jun 27, 2025
e5261cb
Finished add_dimension, add_coordinate, add_variable
dmitriyrepin Jun 28, 2025
95c01d8
Work on build
dmitriyrepin Jun 30, 2025
f391e23
Merge branch 'main' into v1
tasansal Jul 1, 2025
46f82f0
Generalize _to_dictionary()
dmitriyrepin Jul 1, 2025
0dc7cc8
build
dmitriyrepin Jul 1, 2025
fe4af2b
[v1] Update dependencies to latest (#567)
tasansal Jul 2, 2025
79863ac
Dataset Build - pass one
dmitriyrepin Jul 2, 2025
ec480f1
Merge the latest TGSAI/mdio-python:v1 branch
dmitriyrepin Jul 2, 2025
4062a77
unpin zarr because breaking bug fixed (#569)
tasansal Jul 7, 2025
fa81ea2
Merge branch 'v1' into v1
tasansal Jul 7, 2025
4b2b163
Revert .container changes
dmitriyrepin Jul 7, 2025
c532c3b
PR review: remove DEVELOPER_NOTES.md
dmitriyrepin Jul 7, 2025
08798cd
PR Review: add_coordinate() should accept only data_type: ScalarType
dmitriyrepin Jul 7, 2025
e8febe4
PR review: add_variable() data_type remove default
dmitriyrepin Jul 7, 2025
0a4be3f
RE review: do not add dimension variable
dmitriyrepin Jul 8, 2025
7b25d6b
PR Review: get api version from the package version
dmitriyrepin Jul 8, 2025
7ca3ed8
PR Review: remove add_dimension_coordinate
dmitriyrepin Jul 9, 2025
4d1ec9c
PR Review: add_coordinate() remove data_type default value
dmitriyrepin Jul 9, 2025
99fcf43
PR Review: improve unit tests by extracting common functionality in v…
dmitriyrepin Jul 9, 2025
0778fdd
Remove the Dockerfile changes. They are not supposed to be a part of …
dmitriyrepin Jul 9, 2025
7e74567
PR Review: run ruff
dmitriyrepin Jul 9, 2025
0aaa5f6
PR Review: fix pre-commit errors
dmitriyrepin Jul 10, 2025
1904dee
remove some noqa overrides
tasansal Jul 10, 2025
90d31a1
Implement MDIO Dataset builder to create in-memory instance of schema…
dmitriyrepin Jul 10, 2025
4c7c833
Writing XArray / Zarr
dmitriyrepin Jul 10, 2025
4b39ffa
gitignore
dmitriyrepin Jul 10, 2025
e772a4f
Merge remote-tracking branch 'upstream/v1' into v1
dmitriyrepin Jul 11, 2025
cea7308
to_zarr() fix compression
dmitriyrepin Jul 11, 2025
850135e
Fix precommit issues
dmitriyrepin Jul 11, 2025
82f1960
Use only make_campos_3d_acceptance_dataset
dmitriyrepin Jul 11, 2025
b5ee31e
PR Review: address the review comments
dmitriyrepin Jul 14, 2025
7b3ba70
Update _get_fill_value for StructuredType
dmitriyrepin Jul 14, 2025
a4ff4a9
Fix fill type issue for the Structured Types
dmitriyrepin Jul 16, 2025
81bfa76
Improve code coverage
dmitriyrepin Jul 16, 2025
0447659
Fix spelling
dmitriyrepin Jul 17, 2025
d08e2c4
Revert "Fix spelling"
dmitriyrepin Jul 17, 2025
657d2cf
extend per-file ignores for PLR2004 and remove noqa overrides in spec…
tasansal Jul 17, 2025
bfab1d7
Refactor tests: clarify Zarr-related test names, fix type hints, and …
tasansal Jul 17, 2025
9a033de
merge main into v1
tasansal Jul 17, 2025
5878e97
MDIO v1 Templates and Template Registry (#573)
dmitriyrepin Jul 22, 2025
aaf8fc6
Merge branch 'main' into v1
tasansal Aug 6, 2025
bc35bdf
update deps
tasansal Aug 6, 2025
3b62d8f
Merge branch 'main' into v1
tasansal Aug 6, 2025
aae5f51
Merge branch 'main' into v1
tasansal Aug 6, 2025
d21278c
address issues with VS Code dev containers (see issue 559) (#576)
dmitriyrepin Aug 7, 2025
d3a7da2
segy_to_mdio_v1 (#577)
dmitriyrepin Aug 8, 2025
21f64c0
Make some integration tests for work with new `segy_to_mdio` (#599)
dmitriyrepin Aug 12, 2025
4762b7d
remove developer tests
tasansal Aug 12, 2025
db0d564
Serialize text and binary headers (#600)
dmitriyrepin Aug 12, 2025
f5ee136
shot_point (#602)
dmitriyrepin Aug 13, 2025
a8b12f3
Add template: Offset + Azimuth binned CDP gathers (COCA) (#605)
tasansal Aug 15, 2025
0ceccc1
Eager memory allocation fix (#609)
BrianMichell Aug 25, 2025
4116473
Fix memory and core utilization regressions
BrianMichell Aug 26, 2025
fcffad8
Merge pull request #615 from BrianMichell/memory_regression
BrianMichell Aug 26, 2025
faeb616
Export functionality for MDIO v1 ingested files (#611)
dmitriyrepin Sep 3, 2025
db33c2a
v1 implementation of AutoChannelWrap grid override (#632)
dmitriyrepin Sep 5, 2025
379c2f5
Move to Zarr v3 as default for on disk storage format (#630)
tasansal Sep 6, 2025
b8dbb82
fix cloud i/o issue (#637)
tasansal Sep 6, 2025
22bed5c
snake-case to camelCase (#638)
tasansal Sep 6, 2025
9d38e1f
Fix output URI handling for remote stores (#639)
tasansal Sep 6, 2025
4365892
allow legacy v2 support (#640)
tasansal Sep 7, 2025
6562594
Reorganize code and simplify schemas and logic everywhere (#642)
tasansal Sep 7, 2025
642721c
First pass review and alignment of templates (#643)
tasansal Sep 7, 2025
0abe5ac
Fix ingestion of coordinates without full dimensions (#644)
tasansal Sep 8, 2025
b85cc35
Disable unimplemented tests (#647)
tasansal Sep 8, 2025
8931573
Merge branch 'main' into v1
tasansal Sep 8, 2025
e16640b
remove todo, it has correct behaviour, also rename .build_dataset `he…
tasansal Sep 8, 2025
219d354
set version to 1.0.0
tasansal Sep 8, 2025
bef28f8
unpin hardcoded version from tests
tasansal Sep 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove some noqa overrides
  • Loading branch information
tasansal authored Jul 10, 2025
commit 1904deefe7dd58f3d4cb24cbbc682d93f0064926
5 changes: 1 addition & 4 deletions src/mdio/schemas/v1/dataset_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from typing import TypeAlias

from pydantic import BaseModel
from zarr.core.chunk_key_encodings import V2ChunkKeyEncoding # noqa: F401

from mdio.schemas.compressors import ZFP
from mdio.schemas.compressors import Blosc
Expand Down Expand Up @@ -49,7 +48,7 @@
) -> NamedDimension | None:
"""Get a dimension by name and optional size from the list[NamedDimension]."""
if dimensions is None:
return False

Check warning on line 51 in src/mdio/schemas/v1/dataset_builder.py

View check run for this annotation

Codecov / codecov/patch

src/mdio/schemas/v1/dataset_builder.py#L51

Added line #L51 was not covered by tests
if not isinstance(name, str):
msg = f"Expected str, got {type(name).__name__}"
raise TypeError(msg)
Expand Down Expand Up @@ -96,8 +95,8 @@
def __init__(self, name: str, attributes: UserAttributes | None = None):
try:
api_version = metadata.version("multidimio")
except metadata.PackageNotFoundError:
api_version = "unknown"

Check warning on line 99 in src/mdio/schemas/v1/dataset_builder.py

View check run for this annotation

Codecov / codecov/patch

src/mdio/schemas/v1/dataset_builder.py#L98-L99

Added lines #L98 - L99 were not covered by tests

self._info = DatasetInfo(name=name, api_version=api_version, created_on=datetime.now(UTC))
self._attributes = attributes
Expand All @@ -107,9 +106,7 @@
self._state = _BuilderState.INITIAL
self._unnamed_variable_counter = 0

def add_dimension( # noqa: PLR0913
self, name: str, size: int
) -> "MDIODatasetBuilder":
def add_dimension(self, name: str, size: int) -> "MDIODatasetBuilder":
"""Add a dimension.

This function be called at least once before adding coordinates or variables.
Expand Down Expand Up @@ -331,8 +328,8 @@
Dataset: The built dataset with all added dimensions, coordinates, and variables.
"""
if self._state == _BuilderState.INITIAL:
msg = "Must add at least one dimension before building"
raise ValueError(msg)

Check warning on line 332 in src/mdio/schemas/v1/dataset_builder.py

View check run for this annotation

Codecov / codecov/patch

src/mdio/schemas/v1/dataset_builder.py#L331-L332

Added lines #L331 - L332 were not covered by tests

var_meta_dict = _to_dictionary([self._info, self._attributes])
return Dataset(variables=self._variables, metadata=var_meta_dict)
Loading