forked from apache/spark
-
Notifications
You must be signed in to change notification settings - Fork 6
Snap 2084 #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Snap 2084 #86
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a6c4083
[SNAp-2084] Added a check to set Snappy UMM if found in classpath.
78884fb
SparkEnv modified to set SnappyUMM if in classpath.
fb081c5
Merge branch 'snappy/branch-2.1' into SNAP-2084
f7a49b1
Merge branch 'snappy/branch-2.1' into SNAP-2084
9de66c9
Added spark header to avoid scalastyle error.
b9e1247
Changed based on review comments.
eb7a6a4
adding full copyright header.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
core/src/main/scala/org/apache/spark/SparkSnappyUtils.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| /* | ||
| * Copyright (c) 2017 SnappyData, Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you | ||
| * may not use this file except in compliance with the License. You | ||
| * may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or | ||
| * implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. See accompanying | ||
| * LICENSE file. | ||
| */ | ||
| package org.apache.spark | ||
|
|
||
| import org.apache.spark.memory.MemoryManager | ||
| import org.apache.spark.util.Utils | ||
|
|
||
|
|
||
| object SparkSnappyUtils { | ||
|
|
||
| val SNAPPY_UNIFIED_MEMORY_MANAGER_CLASS = "org.apache.spark.memory.SnappyUnifiedMemoryManager" | ||
|
|
||
| def loadSnappyManager(conf: SparkConf, numUsableCores: Int): Option[MemoryManager] = { | ||
| try { | ||
| Some(Utils.classForName(SNAPPY_UNIFIED_MEMORY_MANAGER_CLASS) | ||
| .getConstructor(classOf[SparkConf], classOf[Int]) | ||
| .newInstance(conf, Int.box(numUsableCores)) | ||
| .asInstanceOf[MemoryManager]) | ||
| } catch { | ||
| case ex: ClassNotFoundException => None | ||
| } | ||
| } | ||
|
|
||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An explicit setting of "spark.memory.manager" should override SnappyUMM. So this should be changed in the getOrElse block of previous code: