[SNAP-1252][SNAP-1251] Avoid exchange when join columns are superset of partitioning #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of partitioning columns - LocalJoin now adjusts its requiredChildDistributions to match that of a child in case partial set of join keys match the partitioning of one or both children - check for subset match order to see if the same can be applied to both children, else if both had different matches then choose the child with bigger size as per plan statististics - also add join column aliases from projections, if any, to OrderlessHashPartitioning TODO: add similar to SortMergeJoinExec (or its optimized version in SnappyData when it is added)
hbhanawat
approved these changes
Dec 15, 2016
| case e: Expression => | ||
| val numColumns = e.children.length | ||
| if (keys.length > numColumns) { | ||
| keys.indices.combinations(numColumns).map(s => s.map(keys.apply) -> s) |
Contributor
There was a problem hiding this comment.
combinations.. nice API. Pretty interesting way of writing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
partial set of join keys match the partitioning of one or both children
else if both had different matches then choose the child with bigger size as per plan statististics
TODO: add similar to SortMergeJoinExec (or its optimized version in SnappyData when it is added)
Patch testing
precheckin; TPCH Q2, Q5, Q9 plans, NorthWind test
ReleaseNotes.txt changes
NA
Other PRs
TIBCOSoftware/snappy-spark#37