Skip to content

Improve implementation of AddTypesToNamespaces loader task #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexanderlinne merged 1 commit into from
Sep 26, 2025
Merged

Improve implementation of AddTypesToNamespaces loader task #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: improve implementation of AddTypesToNamespaces loader task 
Signed-off-by: Alexander Linne <[email protected]>
  • Loading branch information
@alexanderlinne
alexanderlinne committed Sep 26, 2025
commit 987d3662a26ea44930f13b841b8c730ea8daf310
15 changes: 5 additions & 10 deletions ArchUnitNET/Loader/ArchBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,15 +113,10 @@ public void LoadTypesForModule(ModuleDefinition module, string namespaceFilter)
}
});

_namespaceRegistry
.Namespaces.Where(ns => RegexUtils.MatchNamespaces(namespaceFilter, ns.FullName))
.ForEach(ns =>
{
_loadTaskRegistry.Add(
typeof(AddTypesToNamespace),
new AddTypesToNamespace(ns, currentTypes)
);
});
_loadTaskRegistry.Add(
typeof(AddTypesToNamespaces),
new AddTypesToNamespaces(currentTypes)
);
}

private void UpdateTypeDefinitions()
Expand All @@ -138,7 +133,7 @@ private void UpdateTypeDefinitions()
typeof(AddGenericArgumentDependencies),
typeof(AddClassDependencies),
typeof(AddBackwardsDependencies),
typeof(AddTypesToNamespace),
typeof(AddTypesToNamespaces),
}
);
}
Expand Down
11 changes: 6 additions & 5 deletions ...T/Loader/LoadTasks/AddTypesToNamespace.cs → .../Loader/LoadTasks/AddTypesToNamespaces.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,21 @@

namespace ArchUnitNET.Loader.LoadTasks
{
internal class AddTypesToNamespace : ILoadTask
internal class AddTypesToNamespaces : ILoadTask
{
private readonly Namespace _ns;
private readonly List<IType> _types;

public AddTypesToNamespace(Namespace ns, List<IType> types)
public AddTypesToNamespaces(List<IType> types)
{
_ns = ns;
_types = types;
}

public void Execute()
{
((List<IType>)_ns.Types).AddRange(_types.Where(type => type.Namespace.Equals(_ns)));
foreach (var type in _types)
{
((List<IType>)type.Namespace.Types).Add(type);
}
}
}
}
Loading