Skip to content

fix: update entry cache when toggling tags #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

fix: update entry cache when toggling tags #1135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/tagstudio/core/library/alchemy/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,11 @@ def __repr__(self) -> str:
def __hash__(self) -> int:
return hash(self.id)

def __eq__(self, value: object) -> bool:
if not isinstance(value, Tag):
return False
return self.id == value.id

def __lt__(self, other: "Tag") -> bool:
return self.name < other.name

Expand Down
10 changes: 6 additions & 4 deletions src/tagstudio/qt/mixed/field_containers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,12 @@ def update_toggled_tag(self, tag_id: int, toggle_value: bool):
tag = self.lib.get_tag(tag_id)
if not tag:
return
new_tags = (
entry.tags.union({tag}) if toggle_value else {t for t in entry.tags if t.id != tag_id}
)
self.update_granular(entry_tags=new_tags, entry_fields=entry.fields, update_badges=False)
if toggle_value:
entry.tags.add(tag)
else:
entry.tags.discard(tag)

self.update_granular(entry_tags=entry.tags, entry_fields=entry.fields, update_badges=False)

def hide_containers(self):
"""Hide all field and tag containers."""
Expand Down