Skip to content

fix(scheduleGarbageCollection): Do not garbage collect newly cached queries of the same hash #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 8, 2020
+42 −3
Merged

fix(scheduleGarbageCollection): Do not garbage collect newly cached queries of the same hash #332

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5c75a8e
Add manual/prefetch cleanup test that fails
kamranayub Apr 8, 2020
3d1aa7a
Prefetch both queries in second test
kamranayub Apr 8, 2020
aa44aa9
Add cleanup comment that will make the tests pass
kamranayub Apr 8, 2020
e30cf94
Store when the GC was initiated and compare against updatedAt
kamranayub Apr 8, 2020
5835d22
Replace solution with state marker check and streamline test
kamranayub Apr 8, 2020
6976cb3
Undo setting.json change
kamranayub Apr 8, 2020
7dbb61a
Undo setting.json change
kamranayub Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add cleanup comment that will make the tests pass
  • Loading branch information
@kamranayub
kamranayub committed Apr 8, 2020
commit aa44aa91b64e0da163100695668e19931652a8ca
4 changes: 4 additions & 0 deletions src/tests/cleanup.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
import React from 'react'
import { render, fireEvent } from '@testing-library/react'
import { cleanup } from '@testing-library/react/pure'
import { queryCache } from '..'
import { Page } from './cleanup'

describe('query cleanup', () => {
afterEach(() => {
queryCache.clear()
// This will make things pass as it force-flushes the microtask queue twice
// but it's a bandaid over an underlying issue
// await cleanup()
})

test('should prefetchQuery by force for first query', async () => {
Expand Down