Fix OTG not loading file lists on Android >= N + refactoring #1959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TranceLove
added
Issue-Bug
- Allow USB device detection on Android >= N - Add back missing dialog.show() in Drawer when asking user to open USB device root at Android DocumentsUI - Moved SSH isDirectory() symlink checks to SshClientUtil - combined MediaStore image/video query methods together + fix arguments
TranceLove
force-pushed
the
bugfix/1951
branch
2 times, most recently
from
b6a51f3 to
422e74f
Compare
routine using SshClientUtils.isDirectory() needs IOException
TranceLove
force-pushed
the
bugfix/1951
branch
from
422e74f to
c6c77da
Compare
VishalNehra
requested changes
Aug 18, 2020
Member
|
Might wanna remove PR_WIP label? ;) |
Collaborator
Author
But be reminded, plug and play may still not work after applying this PR, i.e. need to restart to see the OTG device in the drawer. |
Member
|
Can you make new HybridFileParcelable(smb) change in listFiles -> SFTP and forEachChildrenFile both places as well. |
TranceLove
force-pushed
the
bugfix/1951
branch
from
a98d92b to
53422f0
Compare
- use HybridFileParcelable(SmbFile) for jcifs SmbFile in HybridFile.listFiles() and HybridFile.forEachChildrenFile() - use HybridFileParcelable(RemoteResourceInfo) for sshj RemoteResourceInfo in HybridFile.listFiles() and HybridFile.forEachChildrenFile() - Add javadoc for the 2 new HybridFileParcelable constructors - remove duplicated parseSmbPath() and parseSftpPath() from MainActivityHelper
TranceLove
force-pushed
the
bugfix/1951
branch
from
53422f0 to
a5473eb
Compare
Collaborator
Author
|
See if a5473eb fits. |
Member
|
Sorry my bad, overlooked a bit of the code. |
VishalNehra
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
Issue tracker
Addresses #1951
Release
Addresses release/3.5
Test cases
Manual testing
If yes,
Build tasks success
Successfully running following tasks on local
./gradlew assembledebug./gradlew spotlessCheckAdditional Info
Changes:
Known issue:
Amaze cannot detect USB device inserted while running. Debug mode saw Amaze did able to detect USB and put item drawer, but not at normal run.