Fix ClassCastException at SmbSearchDialog with SMB SubnetScanner #3954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icon should be androidx.appcompat.widget.AppCompatImageView instead
TranceLove
added
Issue-Bug
VishnuSanal
reviewed
Oct 15, 2023
Member
VishnuSanal
left a comment
VishnuSanal
left a comment
There was a problem hiding this comment.
#3885 is a StringIndexOutOfBoundsException, not ClassCastException 🤔
Collaborator
Author
VishnuSanal
added
the
not-yet-rolled
VishalNehra
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, I too think it should have been fixed somewhere else, but now I got one... whatever.
Description
Icon should be androidx.appcompat.widget.AppCompatImageView instead.
Issue tracker
Manual tests
Done
Device: Pixel 7 emulator
OS: Android 14
SMB search dialog should not crash with ClassCastException error when opening.
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck