Bump kotlin, sshj, jcifs-ng and Bouncy Castle dependencies + migrate to libs.versions.toml #4092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eference At ContextLocaleExt.kt, remove conflicting locales API 24 or above
So both sshj and jcifs-ng can use BouncyCastle compiled for JDK 8
This was referenced Feb 25, 2024
TranceLove
changed the title
- Use ksp for faster processing of source code - Migrate code from using generated Glide classes to recommended ones - Bump AndroidX annotation, Room and Glide versions - Bump Kotlin to 1.9.10 - Migrate version and lib names to libs.versions.toml
3 tasks
VishalNehra
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump sshj, jcifs-ng and Bouncy Castle dependencies, in response to #4091
Additionally,
kspfor faster processing of source codelibs.versions.tomlIssue tracker
Fixes #4091
Fixes #4088
Automatic tests
Manual tests
Done
Device: Pixel 6 emulator
OS: Android 13
SMB and SSH connections should continue to work
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheckRelated PR
Related to PR #4085, the same e7eb3d8 was cherry-picked into this PR to keep the test pass