Skip to content

Conversation

@msaqeeb72
Copy link
Contributor

@msaqeeb72 msaqeeb72 commented Apr 17, 2024

Bookmark Crashed Issue Fixed, added check for empty name and valid path before adding bookmark.

fixes #4143

Description

Issue tracker

Automatic tests

  • Added test cases

Manual tests

  • Done

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

Copy link
Member

@VishnuSanal VishnuSanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected in testing, looks good to me, good to go! 🚀

@Thejas775
Copy link

@VishnuSanal is this pr waiting for some changes? or is the issue solved ?

@VishnuSanal
Copy link
Member

@VishnuSanal is this pr waiting for some changes? or is the issue solved ?

It is waiting for approval/reviews from other maintainers, if they give approvals too, it'll be good to be merged.

@VishalNehra VishalNehra merged commit bedb4ae into TeamAmaze:release/4.0 Jul 8, 2024
@VishalNehra
Copy link
Member

Thanks for your contribution. Please feel free to contact at t.me/AmazeFileManager to collect bounty for resolving this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Creating a bookmark with empty directory causes error when attempting to open the bookmark

4 participants