fix last modified timestamps not getting preserved #4171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VishnuSanal
added
Issue-Severe (high)
Member
Author
|
build test apk |
|
The requested APKs has been built. Please find them from the artifacts section of this PR. |
VishnuSanal
changed the title
TranceLove
reviewed
May 21, 2024
| if (getFile().setLastModified(date)) return true; | ||
|
|
||
| try { | ||
| Files.setLastModifiedTime(getFile().toPath(), FileTime.fromMillis(date)); |
Collaborator
There was a problem hiding this comment.
What if it runs on Android < 8? Perhaps you may need to trap Exceptions like NoSuchMethodException as well.
(Although I too expect minimal Android version requirement would need to be raised soon as well)
Member
Author
There was a problem hiding this comment.
trapping NoSuchMethodException gives a compiler error. did version checking to avoid this issue.
VishalNehra
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue tracker
fixes #892
Automatic tests
Manual tests
Done
tested on A14 (cut, copy) * (file, directory).
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck