Skip to content

fix build fails #4245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VishalNehra merged 3 commits into from
Oct 8, 2024
Merged

fix build fails #4245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04a41a5
fix(ci): update `fabSpeedDial` version
VishnuSanal Aug 24, 2024
68cd53a
fix(ci): remove `com.github.pengrad:jdk9-deps:1.0`
VishnuSanal Aug 29, 2024
5e832d9
add fab speed dial tint (ref: https://github.com/leinardi/FloatingAct…
VishnuSanal Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/java/com/amaze/filemanager/ui/activities/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1908,7 +1908,8 @@ private FabWithLabelView initFabTitle(
SpeedDialActionItem.Builder builder =
new SpeedDialActionItem.Builder(id, icon)
.setLabel(fabTitle)
.setFabBackgroundColor(iconSkin);
.setFabBackgroundColor(iconSkin)
.setFabImageTintColor(Color.WHITE);

switch (getAppTheme()) {
case LIGHT:
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ subprojects {
}
}
dependencies {
compileOnly 'com.github.pengrad:jdk9-deps:1.0'
// compileOnly 'com.github.pengrad:jdk9-deps:1.0'
Copy link
Member Author

@VishnuSanal VishnuSanal Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TranceLove what were this dependency used for? this causes the build failure. the builds pass even without this; can we safely remove it?

Copy link
Collaborator

@TranceLove TranceLove Sep 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was introduced when moving towards JDK 9 per #1941. Perhaps this is no longer needed when officially Android apps can build with JDK 11/17?

Copy link
Member Author

@VishnuSanal VishnuSanal Sep 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was introduced when moving towards JDK 9 per #1941. Perhaps this is no longer needed when officially Android apps can build with JDK 11/17?

Code complies & the tests pass -- shouldn't it be good? 🤔


if (project.hasProperty('kapt')) {
kapt 'javax.xml.bind:jaxb-api:2.3.1'
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ glide = "4.14.2"
sshj = "0.35.0"
jcifs = "2.1.9"
eventbus = "3.3.1"
fabSpeedDial = "3.1.1"
fabSpeedDial = "3.3.0"
room = "2.5.2"
bouncyCastle = "1.76"
awaitility = "3.1.6"
Expand Down