Skip to content

Conversation

@TranceLove
Copy link
Collaborator

Description

Seems some commits that were in release/3.10 didn't go to release/4.0 yet... hence this PR to pick them up.

Manual tests

  • Done

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

TranceLove and others added 5 commits July 9, 2024 21:10
Upgrade Google Play Billing library to 6.0.1
…oser() to get PEM content

To fix regressions in newer Androids that SftpConnectDialog unable to load PEM for SSH authentication.

Reference: https://stackoverflow.com/questions/10002065/android-gallery-always-returns-result-canceled-to-onactivityresult
…ct-pem

SftpConnectDialog: Wrap open DocumentsUI intent with Intent.createChooser() to get PEM content
Copy link
Member

@VishnuSanal VishnuSanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, nice catch!

@VishnuSanal VishnuSanal added the PR-Awaiting-Final-Review this PR is awaiting a final review/approval label Dec 13, 2024
Copy link
Member

@EmmanuelMess EmmanuelMess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming that it works for release 3.10

@EmmanuelMess EmmanuelMess merged commit 95f567b into release/4.0 Feb 9, 2025
1 check passed
@EmmanuelMess EmmanuelMess deleted the bugfix/merge-3.10 branch April 18, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Awaiting-Final-Review this PR is awaiting a final review/approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants