Option for delete permanently on single click #4290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VishnuSanal
added
the
PR-Awaiting-Initial-Review
VishnuSanal
requested changes
Dec 13, 2024
Member
VishnuSanal
left a comment
VishnuSanal
left a comment
There was a problem hiding this comment.
hi, thanks for your interest in contributing to amaze! please see the comments for reviews.
VishnuSanal
added
PR-Requested-Changes
VishnuSanal
requested changes
Dec 13, 2024
Member
VishnuSanal
left a comment
VishnuSanal
left a comment
There was a problem hiding this comment.
@yashwanthgajji some more changes:
please add the info that this disables the trashbin to the description.
also, we should still show the confirmation dialog if "delete confirmation" is checked. the current implementation essentially revokes that previous setting!
thanks!
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
VishnuSanal
requested changes
Dec 18, 2024
VishnuSanal
approved these changes
Dec 19, 2024
Member
VishnuSanal
left a comment
VishnuSanal
left a comment
There was a problem hiding this comment.
LGTM, great work, keep going! :) 🚀
VishnuSanal
added
PR-Awaiting-Final-Review
EmmanuelMess
approved these changes
May 14, 2025
EmmanuelMess
removed
the
PR-Awaiting-Final-Review
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an option in behavior settings for delete permanently check box. When enabled, it disables the functionality of trash bin and delete files permanently.
Issue tracker
Fixes #4277
Automatic tests
Manual tests
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck