Skip to content

Conversation

@TranceLove
Copy link
Collaborator

Description

To fix crash when starting FtpService by declaring foregroundServiceType="dataSync"

Issue tracker

Fixes #4377

Manual tests

  • Done

  • Pixel 3 emulator running stock Android 9

  • Pixel 7 emulator running stock Android 15
    Both devices could start FtpService from the FtpServerFragment or through tile without crashing the app.

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

@Bambooin
Copy link
Contributor

Bambooin commented Apr 3, 2025

Verified with device, it's fixed with this patch.

@TranceLove TranceLove mentioned this pull request Apr 6, 2025
4 tasks
@VishnuSanal VishnuSanal added the PR-Awaiting-Final-Review this PR is awaiting a final review/approval label Apr 14, 2025
@EmmanuelMess
Copy link
Member

Verified with device, it's fixed with this patch.

If you can verify on device, and code is up to standard, then you should officially approve as a reviewer.

@EmmanuelMess EmmanuelMess merged commit 94a699e into release/4.0 Apr 16, 2025
4 checks passed
@EmmanuelMess EmmanuelMess deleted the bugfix/4377 branch April 16, 2025 22:28
@Bambooin
Copy link
Contributor

Verified with device, it's fixed with this patch.
If you can verify on device, and code is up to standard, then you should officially approve as a reviewer.

I can verify the pull request with Android phone, you can add me as the reviewer, thanks.

I am a heavy daily Amaze user and I often build it from the pull request for the latest feature or fix.

Ftp server is the main usage for me to transfer the files between Linux and macOS machines with Adroid phone.

@VishnuSanal
Copy link
Member

Verified with device, it's fixed with this patch.
If you can verify on device, and code is up to standard, then you should officially approve as a reviewer.

I can verify the pull request with Android phone, you can add me as the reviewer, thanks.

I am a heavy daily Amaze user and I often build it from the pull request for the latest feature or fix.

Ftp server is the main usage for me to transfer the files between Linux and macOS machines with Adroid phone.

thanks for your long term support! + the nice words. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Awaiting-Final-Review this PR is awaiting a final review/approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail to start the FTP server with regression

5 participants