Adaptations to enable 16KB page size support #4450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Forcing use of NDK 28c (if applicable) - CMakeLists.txt add linker flag to force page size of 16KB - Added setup NDK step in Github Actions workflow to force use of NDK 28c
Collaborator
Author
|
After this change, the built APK still has the not supporting 16KB devices nag. 
But if app bundle AAB is built, no warning was given, which should comply - we shall be uploading AAB instead of APKs to Google Play Store anyway. 
|
TranceLove
added
Area-CodeHealth
There was a problem hiding this comment.
Pull Request Overview
This PR implements Android 16KB page size support in response to Google Play's requirements for newer devices, focusing on NDK and build system adaptations.
- Forces use of NDK 28c across all build configurations
- Adds CMake linker flag to enforce 16KB page size for native libraries
- Updates GitHub Actions workflows to consistently use NDK 28c
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gradle/libs.versions.toml | Adds NDK version specification (28c) to centralized version catalog |
| file_operations/src/main/c/CMakeLists.txt | Adds linker flag to enforce 16KB page size for native library |
| file_operations/build.gradle | References NDK version from version catalog |
| .github/workflows/*.yml | Adds NDK setup steps to all GitHub Actions workflows |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
EmmanuelMess
approved these changes
Aug 28, 2025
Member
EmmanuelMess
left a comment
EmmanuelMess
left a comment
There was a problem hiding this comment.
Looks good, there should not be any visible changes in the app.
VishnuSanal
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In response to Google Play's notice for supporting 16KB devices.
Manual tests
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck