fix: selected item is unselected after clicking 'Select All' when there is only one item in the directory #4452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rahulraj888
commented
Sep 3, 2025
app/src/main/java/com/amaze/filemanager/ui/selection/SelectionPopupMenu.kt
Show resolved
Hide resolved
VishnuSanal
added
the
PR-Awaiting-Initial-Review
EmmanuelMess
approved these changes
Sep 4, 2025
VishnuSanal
added
PR-Awaiting-Final-Review
VishnuSanal
changed the title
VishalNehra
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4327
Describe the bug
When there is only one item in the Trash Bin, the selected item is cancelled after clicking 'Select All'
To Reproduce
Steps to reproduce the behavior:
Click on 'Hamburger' menu
Click on 'Trash Bin'
Long press to select an item
Click on 'v' icon
Click on 'Select All'
Expected behavior
The selected item should remain selected after clicking ‘Select All’, even if it is the only item in the Trash Bin
Test Case scenarios's checked:
Device: Samsung Galaxy S24 (SM-S921W).