This repository was archived by the owner on Sep 14, 2024. It is now read-only.
Material 3 #184
Merged
Material 3 #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leptopoda
force-pushed
the
material-3
branch
2 times, most recently
from
2f8b662 to
a5b0224
Compare
Leptopoda
force-pushed
the
material-3
branch
2 times, most recently
from
cb6aa3e to
86b352c
Compare
Collaborator
Author
|
Ok as to not bloat this PR further I'll mark as ready as it. Problems so far:
@Teifun2 will you have time to review or should I just merge? |
Merged
Leptopoda
commented
Apr 10, 2023
added 9 commits
April 18, 2023 13:50
- enables material 3 theme - redo the design of some buttons - add tooltip to every icon button to improve both usability and accessability - uses the nextcloud blue for the color scheme - rework theme handling
- center
- Implement uncategorized category - propperly pluralize the category screen
added 8 commits
April 18, 2023 13:50
- use the nextcloud stlye faded background ("borrowed" from the NC-Passwords app)
- fix the size of the android foreground to better fit the adaptive icon
- validate input to be a url - enable submitting with the keyboard
Teifun2
approved these changes
Apr 21, 2023
Teifun2
approved these changes
Apr 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #171
Now we finally come to the reason why I migrated the backend :)
This is a peek at what I did behind the scenes.
I hope you all enjoy the fresh look and waaaaaay better performance. I'll test on my fairly old samsung s4 but it doesn't feel sluggish on scrolling anymore.
Now to the big question: WHY IS THIS A DRAFT? I want this asap!?
While it could be merged as is I have a few places where the design can still be improved and I'll make my final touchups.
A list of what I'm still thinking of:
[ ] category name scaling[ ] better one hand use on recipe import screen[ ] maybe use a SliverAppBar for the RecipeScreen for some fancy UI[ ] fixup login screenPlease note that I originally started the redesign under flutter 3.6 and flutter 3.7 changed a lot regarding m3. The coloring might be off in some places and I'm actively fixing them.