Fix for missing activity error on platform re-add

README.md

@@ -111,6 +111,9 @@ Note that backward compatibility was added by checking for read permission autom
 If permission is needed the plugin will now show the permission request popup.
 The user will then need to allow access and invoke the same method again after doing so.
 
+## Android 10 (Q) Permissions/Storage
+Android 10/11 included various [storage updates](https://developer.android.com/about/versions/11/privacy/storage).  This plugin is not fully compatible with these updates, and as such requires the `requestLegacyExternalStorage` property to be set in the android manifest in order to run on Android 10 devices.  This also will require targetting API level 29 (but this is already a google play store requirement as of November 2020).  
+
 
 ## Libraries used
 

plugin.xml

@@ -92,14 +92,13 @@
 
     <!-- android -->
     <platform name="android">
+        <hook type="after_prepare" src="scripts/android_manifest_update.js" />
+
         <config-file target="res/xml/config.xml" parent="/*">
             <feature name="ImagePicker">
                 <param name="android-package" value="com.synconset.ImagePicker"/>
             </feature>
         </config-file>
-        <edit-config file="app/src/main/AndroidManifest.xml" mode="merge" target="/manifest/application">
-            <application android:requestLegacyExternalStorage="true" />
-        </edit-config>
         <config-file target="AndroidManifest.xml" parent="/manifest/application">
             <activity android:label="@string/multi_app_name" android:name="com.synconset.MultiImageChooserActivity" android:theme="@style/Theme.AppCompat.Light">
             </activity>

scripts/android_manifest_update.js

@@ -0,0 +1,45 @@
+#!/usr/bin/env node
+
+module.exports = function (context) {
+
+    var fs = require('fs');
+    var path = require('path');
+    var manifestDirectory = path.join(context.opts.projectRoot, '/platforms/android/app/src/main/');
+    var manifestFile = path.join(manifestDirectory, 'AndroidManifest.xml');
+
+    var LEGACY_STORAGE_ATTRIBUTE = 'android:requestLegacyExternalStorage';
+    var LEGACY_STORAGE_VALUE = LEGACY_STORAGE_ATTRIBUTE + '="true"';
+    var LEGACY_STORAGE_REGEX = new RegExp(LEGACY_STORAGE_ATTRIBUTE + '="([^"]+)"');
+
+    fs.exists(manifestDirectory, function (exists) {
+        if (!exists) {
+            console.log('Manifest directory not found. No image-picker updates.');
+        }
+        else {
+
+            fs.readFile(manifestFile, 'utf8', function (err, data) {
+                if (err) {
+                    throw new Error('Unable to read AndroidManifest.xml: ' + err);
+                }
+
+                var updatedManifest;
+
+                //Add the android:requestLegacyExternalStorage value in the manifest
+                if (!data.match(LEGACY_STORAGE_ATTRIBUTE)) {
+                    updatedManifest = data.replace(/<application/g, '<application ' + LEGACY_STORAGE_VALUE + ' ');
+                }
+                //update the android:requestLegacyExternalStorage value in the manifest, if it's not set to true
+                else if (data.match(LEGACY_STORAGE_REGEX) && !data.match(LEGACY_STORAGE_VALUE)) {
+                    updatedManifest = data.replace(LEGACY_STORAGE_REGEX, LEGACY_STORAGE_VALUE);
+                }
+
+                //Update the actual file - write it out
+                if (updatedManifest) {
+                    fs.writeFile(manifestFile, updatedManifest, 'utf8', function (err) {
+                        if (err) throw new Error('Unable to write AndroidManifest.xml: ' + err);
+                    })
+                }
+            });
+        }
+    });
+}