Skip to content

fix: Directory.Move fails on Windows if destination has different case from source #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbreuss merged 7 commits into from
Apr 18, 2025
Merged

fix: Directory.Move fails on Windows if destination has different case from source #1256

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4746326
corrected logic
oni-shiro Apr 15, 2025
feaa2d1
added method in StringOperations.cs
oni-shiro Apr 15, 2025
50e5585
test: updated the expected test case
oni-shiro Apr 15, 2025
2f73221
chore: removed extra spaces
oni-shiro Apr 15, 2025
b526929
chore: corrected comment
oni-shiro Apr 15, 2025
402f597
feat: removed the overload on public api
oni-shiro Apr 16, 2025
99b2fd7
feat: refactored the logic
oni-shiro Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
feat: refactored the logic
  • Loading branch information
@oni-shiro
oni-shiro committed Apr 18, 2025
commit 99b2fd7276cfe8ddfa7d4d8e7b31efd7f66abe65
16 changes: 5 additions & 11 deletions src/TestableIO.System.IO.Abstractions.TestingHelpers/MockDirectory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,8 +503,7 @@ public override void Move(string sourceDirName, string destDirName)
var fullSourcePath = mockFileDataAccessor.Path.GetFullPath(sourceDirName).TrimSlashes();
var fullDestPath = mockFileDataAccessor.Path.GetFullPath(destDirName).TrimSlashes();

if (XFS.IsUnixPlatform() ? mockFileDataAccessor.StringOperations.Equals(fullSourcePath, fullDestPath)
: string.Equals(fullSourcePath, fullDestPath, StringComparison.Ordinal))
if (string.Equals(fullSourcePath, fullDestPath, StringComparison.Ordinal))
{
throw new IOException("Source and destination path must be different.");
}
Expand Down Expand Up @@ -535,17 +534,12 @@ public override void Move(string sourceDirName, string destDirName)
{
throw CommonExceptions.CouldNotFindPartOfPath(destDirName);
}
if (XFS.IsUnixPlatform())
{
if (mockFileDataAccessor.Directory.Exists(fullDestPath) || mockFileDataAccessor.File.Exists(fullDestPath))
{
throw CommonExceptions.CannotCreateBecauseSameNameAlreadyExists(fullDestPath);
}
}
else if (!string.Equals(fullSourcePath, fullDestPath, StringComparison.OrdinalIgnoreCase))

if (mockFileDataAccessor.Directory.Exists(fullDestPath) || mockFileDataAccessor.File.Exists(fullDestPath))
{
// In Windows, file/dir names are case sensetive, C:\\temp\\src and C:\\temp\\SRC and treated different
if (mockFileDataAccessor.Directory.Exists(fullDestPath) || mockFileDataAccessor.File.Exists(fullDestPath))
if (XFS.IsUnixPlatform() ||
!string.Equals(fullSourcePath, fullDestPath, StringComparison.OrdinalIgnoreCase))
{
throw CommonExceptions.CannotCreateBecauseSameNameAlreadyExists(fullDestPath);
}
Expand Down