Skip to content

Theme used for Traceback should not inherit defaults#1811

Merged
willmcgugan merged 8 commits intomasterfrom
1786-traceback-theme-inheritance
Jan 7, 2022
Merged

Theme used for Traceback should not inherit defaults#1811
willmcgugan merged 8 commits intomasterfrom
1786-traceback-theme-inheritance

Conversation

@darrenburns
Copy link
Member

@darrenburns darrenburns commented Jan 6, 2022

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

A Theme was instantiate to contain the styles used in the rendering of a traceback. This theme by default inherited the default styles, which in turn would override the user-supplied theme.

@darrenburns darrenburns linked an issue Jan 6, 2022 that may be closed by this pull request
@darrenburns darrenburns marked this pull request as ready for review January 6, 2022 20:22
@willmcgugan
Copy link
Member

👍

@willmcgugan willmcgugan merged commit 20b30b7 into master Jan 7, 2022
@willmcgugan willmcgugan deleted the 1786-traceback-theme-inheritance branch January 7, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Modifying console theme has no effect on traceback

2 participants