Skip to content

Conversation

@darrenburns
Copy link
Member

@darrenburns darrenburns commented Feb 10, 2022

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Changes the definition of the Rich markup tags such that they cannot contain a [ inside them, and handles escaping of [ that previously was considered to be a tag, but is now considered part of plain text.

image

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.81%. Comparing base (e839bfb) to head (fa927d9).
Report is 1751 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1950      +/-   ##
==========================================
- Coverage   99.82%   99.81%   -0.02%     
==========================================
  Files          71       71              
  Lines        6943     7034      +91     
==========================================
+ Hits         6931     7021      +90     
- Misses         12       13       +1     
Flag Coverage Δ
unittests 99.81% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@willmcgugan willmcgugan merged commit d06540a into master Feb 11, 2022
@willmcgugan willmcgugan deleted the markup-escaping branch February 11, 2022 11:05
This was referenced Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

console markup escaping issue [BUG] List of numpy arrays does not print correctly

4 participants