Handle case inspect fails on repl-defined objects#2037
Merged
willmcgugan merged 2 commits intomasterfrom Mar 8, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2037 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 71 71
Lines 7058 7058
=======================================
Hits 7045 7045
Misses 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This was referenced Mar 10, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Objects defined in a REPL are part of the
__main__scope, which doesn't have a corresponding file, and sorich.inspectwas failing when trying to find this filename.inspect.getfileraises anOSErrorin this case.We catch the
OSErrorand ignore it, as the rest of the code already handles the case where there is nosource_filenameavailable.Closes #2033