Handle recording on legacy mode Windows consoles#2066
Merged
willmcgugan merged 11 commits intomasterfrom Mar 18, 2022
Merged
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2066 +/- ##
==========================================
- Coverage 99.52% 99.45% -0.07%
==========================================
Files 72 72
Lines 7335 7344 +9
==========================================
+ Hits 7300 7304 +4
- Misses 35 40 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… windows-capture-fix
willmcgugan
requested changes
Mar 15, 2022
Member
Author
|
@willmcgugan |
willmcgugan
approved these changes
Mar 18, 2022
This was referenced Mar 22, 2022
1 task
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Console.record=True was only being handled inside
_render_buffer, which was not called on legacy mode consoles.I've extracted the code for recording the buffer out of this method, to ensure it gets called regardless of environment.
Closes #2053