Skip to content

SVG export - Safari - Prevent box appearing on rounded corners #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darrenburns merged 4 commits into from
Apr 20, 2022
Merged

SVG export - Safari - Prevent box appearing on rounded corners #2201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06aa127
Merge branch 'master' of github.com:Textualize/rich
darrenburns Apr 19, 2022
bf728db
Merge branch 'master' of github.com:Textualize/rich
darrenburns Apr 19, 2022
5d935e0
Use box-shadow instead of outline for Safari support
darrenburns Apr 19, 2022
f7ea7ff
Update changelog re Safari SVG export square corner bug
darrenburns Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Fall back to `sys.__stderr__` on POSIX systems when trying to get the terminal size (fix issues when Rich is piped to another process)
- Fixed markup escaping issue https://github.com/Textualize/rich/issues/2187
- Safari - Box appearing around SVG export https://github.com/Textualize/rich/pull/2201

## [12.2.0] - 2022-04-05

Expand Down
2 changes: 1 addition & 1 deletion rich/_export_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
align-items: center;
background-color: {theme_background_color};
border-radius: 14px;
outline: 1px solid #484848;
box-shadow: 0 0 0 1px #484848;
}}
.{classes_prefix}-terminal:after {{
position: absolute;
Expand Down
2 changes: 1 addition & 1 deletion tests/test_console.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ def test_export_html_inline():
align-items: center;
background-color: #0c0c0c;
border-radius: 14px;
outline: 1px solid #484848;
box-shadow: 0 0 0 1px #484848;
}
.rich-svg-${SVG_HASH}-terminal:after {
position: absolute;
Expand Down