Fixed Style hash #2346
Merged
Fixed Style hash #2346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2346 +/- ##
==========================================
- Coverage 98.88% 98.71% -0.18%
==========================================
Files 73 73
Lines 7629 7761 +132
==========================================
+ Hits 7544 7661 +117
- Misses 85 100 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
willmcgugan
requested review from
darrenburns and
olivierphi
and removed request for
darrenburns and
olivierphi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a performance bug in the Style class.
Essentially the hash calculation was inconsistent. Things that were equal would sometimes have different hashes. I noticed this when adding
lru_cachetoStyle.__add__. What should have been an easy win caused dramatically reduced performance, because it broken the mechanics of storing Styles in a dict.The hashing is now in once place. It is also lazy, so the hash is stored the first time it is used.