Skip to content

Conversation

@TomJGooding
Copy link
Contributor

@TomJGooding TomJGooding commented Feb 29, 2024

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Fixes #3295. I've tested manually but I'm afraid not sure how to add a proper test for this.

Before:

image

After:

image

@TomJGooding TomJGooding marked this pull request as ready for review February 29, 2024 21:16
@TomJGooding
Copy link
Contributor Author

TomJGooding commented Feb 29, 2024

I've now added a test based on the others, where I assume you just copy paste the result from print(repr(result)) and then check that? (If Will has actually written these by hand I'm seriously impressed!)

If that's not the proper way to test this, please let me know!

Copy link
Member

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@willmcgugan willmcgugan merged commit 15d5977 into Textualize:master Jul 1, 2024
@TomJGooding TomJGooding deleted the fix-syntax-include-padding-with-background-color-override branch May 1, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Overriding background_color of Syntax doesn't include padding

2 participants