Fix bug #543: Unstable behavior in PredictRating() #544
+73
−144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#543 Unstable behavior in PredictRating() unit test due to constructor field shadowing
Affected module
CollaborativeFilteringTests.cs
Root Cause
The instability was not caused by the algorithm itself, but by the test fixture design:
[SetUp]
methods overwrite these fields while this test is still executing..Returns(0.8)
) is replaced mid-run by a fresh, unconfigured instance, causing:Fix Summary
Use the
[NonParallelizable]
flagUnit Test Passed Evidence