Skip to content

Conversation

@louvelbr
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Issue number : #2832

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.

@siriak
Copy link
Member

siriak commented Nov 24, 2021

Hi, the build is failing with the following error: ./src/main/java/com/thealgorithms/others/HappyNumbersSeq.java:4: error: class HappyNumSeqTest is public, should be declared in a file named HappyNumSeqTest.java
public class HappyNumSeqTest {
^
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

yanglbme
yanglbme previously approved these changes Nov 25, 2021
@yanglbme
Copy link
Member

Hi @siriak , please review again.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple of small comments, everything else looks good :)

@siriak siriak merged commit e488b7b into TheAlgorithms:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants