Skip to content

Refactored some files to remove code smells. #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 21, 2022
Merged

Refactored some files to remove code smells. #2982

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c11f38a
Refactoring HillCipher, SinglyLinkedList and DoublyLinkedList. Rename…
Mar 17, 2022
c8838a2
Refactoring HillCipher, SinglyLinkedList and DoublyLinkedList. Rename…
Mar 17, 2022
8580744
Removed unnecessary comment slashes
Mar 17, 2022
b4fe027
Removed unnecessary object creations of Doubly Linked List.
Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Removed unnecessary object creations of Doubly Linked List.
  • Loading branch information
Rushi committed Mar 21, 2022
commit b4fe027caa0e9a3bad72fbe104185dee634bb694
38 changes: 18 additions & 20 deletions src/main/java/com/thealgorithms/datastructures/lists/DoublyLinkedList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public DoublyLinkedList(int[] array) {
throw new NullPointerException();
}
for (int i : array) {
linkOperations.insertTail(i);
linkOperations.insertTail(i,this);
}
size = array.length;
}
Expand Down Expand Up @@ -136,13 +136,13 @@ public void displayLink() {
public static void main(String args[]) {
DoublyLinkedList myList = new DoublyLinkedList();
LinkOperations linkOperations = new LinkOperations();
linkOperations.insertHead(13);
linkOperations.insertHead(7);
linkOperations.insertHead(10);
linkOperations.insertHead(13,myList);
linkOperations.insertHead(7,myList);
linkOperations.insertHead(10,myList);
myList.display(); // <-- 10(head) <--> 7 <--> 13(tail) -->
myList.displayBackwards();

linkOperations.insertTail(11);
linkOperations.insertTail(11,myList);
myList.display(); // <-- 10(head) <--> 7 <--> 13 <--> 11(tail) -->
myList.displayBackwards();

Expand All @@ -154,11 +154,11 @@ public static void main(String args[]) {
myList.display(); // <-- 10(head) <--> 13(tail) -->
myList.displayBackwards();

linkOperations.insertOrdered(23);
linkOperations.insertOrdered(67);
linkOperations.insertOrdered(3);
linkOperations.insertOrdered(23,myList);
linkOperations.insertOrdered(67,myList);
linkOperations.insertOrdered(3,myList);
myList.display(); // <-- 3(head) <--> 10 <--> 13 <--> 23 <--> 67(tail) -->
linkOperations.insertElementByIndex(5, 1);
linkOperations.insertElementByIndex(5, 1,myList);
myList.display(); // <-- 3(head) <--> 5 <--> 10 <--> 13 <--> 23 <--> 67(tail) -->
myList.displayBackwards();
linkOperations.reverse(); // <-- 67(head) <--> 23 <--> 13 <--> 10 <--> 5 <--> 3(tail) -->
Expand All @@ -167,7 +167,7 @@ public static void main(String args[]) {
linkOperations.clearList();
myList.display();
myList.displayBackwards();
linkOperations.insertHead(20);
linkOperations.insertHead(20,myList);
myList.display();
myList.displayBackwards();
}
Expand Down Expand Up @@ -196,9 +196,8 @@ class LinkOperations{
*
* @param x Element to be inserted
*/
public void insertHead(int x) {
public void insertHead(int x,DoublyLinkedList doublyLinkedList) {
Link newLink = new Link(x); // Create a new link with a value attached to it
DoublyLinkedList doublyLinkedList = new DoublyLinkedList();
if (doublyLinkedList.isEmpty()) // Set the first element added to be the tail
{
tail = newLink;
Expand All @@ -215,9 +214,8 @@ public void insertHead(int x) {
*
* @param x Element to be inserted
*/
public void insertTail(int x) {
public void insertTail(int x,DoublyLinkedList doublyLinkedList) {
Link newLink = new Link(x);
DoublyLinkedList doublyLinkedList = new DoublyLinkedList();
newLink.next = null; // currentTail(tail) newlink -->
if (doublyLinkedList.isEmpty()) { // Check if there are no elements in list then it adds first element
tail = newLink;
Expand All @@ -236,15 +234,15 @@ public void insertTail(int x) {
* @param x Element to be inserted
* @param index Index(from start) at which the element x to be inserted
*/
public void insertElementByIndex(int x, int index) {
public void insertElementByIndex(int x, int index,DoublyLinkedList doublyLinkedList) {
if (index > size) {
throw new IndexOutOfBoundsException("Index: " + index + ", Size: " + size);
}
if (index == 0) {
insertHead(x);
insertHead(x,doublyLinkedList);
} else {
if (index == size) {
insertTail(x);
insertTail(x,doublyLinkedList);
} else {
Link newLink = new Link(x);
Link previousLink = head; //
Expand Down Expand Up @@ -331,7 +329,7 @@ public void delete(int x) {
*
* @param x Element to be added
*/
public void insertOrdered(int x) {
public void insertOrdered(int x,DoublyLinkedList doublyLinkedList) {
Link newLink = new Link(x);
Link current = head;
while (current != null && x > current.value) // Find the position to insert
Expand All @@ -340,9 +338,9 @@ public void insertOrdered(int x) {
}

if (current == head) {
insertHead(x);
insertHead(x,doublyLinkedList);
} else if (current == null) {
insertTail(x);
insertTail(x,doublyLinkedList);
} else { // Before: 1 <--> 2(current) <--> 3
newLink.previous = current.previous; // 1 <-- newLink
current.previous.next = newLink; // 1 <--> newLink
Expand Down