Skip to content

refactor: optimize ValidParentheses methods and add parameterized tests #6352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025
Merged

refactor: optimize ValidParentheses methods and add parameterized tests #6352

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d8f87b
refactor: optimize ValidParentheses methods and add parameterized tests
alxkm Jul 7, 2025
cc6e0e1
refactor: fix clang formatting issues
alxkm Jul 7, 2025
2588cdc
refactor: fix spotbugs issue
alxkm Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor: fix spotbugs issue
  • Loading branch information
@alxkm
alxkm committed Jul 7, 2025
commit 2588cdcbce609574672f58c742db719bbfcbed36
10 changes: 2 additions & 8 deletions src/test/java/com/thealgorithms/strings/ValidParenthesesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,14 @@

import static org.junit.jupiter.api.Assertions.assertEquals;

import java.util.stream.Stream;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;
import org.junit.jupiter.params.provider.CsvSource;

public class ValidParenthesesTest {

@ParameterizedTest(name = "Input: \"{0}\" → Expected: {1}")
@MethodSource("parenthesesProvider")
@CsvSource({"'()', true", "'()[]{}', true", "'(]', false", "'{[]}', true", "'([{}])', true", "'([)]', false", "'', true", "'(', false", "')', false"})
void testIsValid(String input, boolean expected) {
assertEquals(expected, ValidParentheses.isValid(input));
}

static Stream<Arguments> parenthesesProvider() {
return Stream.of(Arguments.of("()", true), Arguments.of("()[]{}", true), Arguments.of("(]", false), Arguments.of("{[]}", true), Arguments.of("([{}])", true), Arguments.of("([)]", false), Arguments.of("", true), Arguments.of("(", false), Arguments.of(")", false));
}
}
Loading