Skip to content

Add Floyd's Cycle Detection Algorithm #10833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Add Floyd's Cycle Detection Algorithm #10833

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a2c647
Add Floyd's Cycle Detection Algorithm
aqib-m31 Oct 23, 2023
b5648b8
Add tests for add_node function
aqib-m31 Oct 23, 2023
b5e0cf8
Apply suggestions from code review
tianyizheng02 Oct 23, 2023
53973b6
Update floyds_cycle_detection.py
tianyizheng02 Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update floyds_cycle_detection.py
  • Loading branch information
@tianyizheng02
tianyizheng02 authored Oct 23, 2023
commit 53973b67a0a43eb51a5e283595fb313f5360219f
4 changes: 2 additions & 2 deletions data_structures/linked_list/floyds_cycle_detection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@ def __iter__(self) -> Iterator:
>>> tuple(linked_list)
(1,)
"""
visited = set()
visited = []
node = self.head
while node:
# Avoid infinite loop in there's a cycle
if node in visited:
return
visited.add(node)
visited.append(node)
yield node.data
node = node.next_node

Expand Down